Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C front-end: refuse duplicate declaration of local variable #8160

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

tautschnig
Copy link
Collaborator

Just like GCC, Clang, or Visual Studio we should reject duplicate declarations of local variables in the same scope.

Fixes: #8129

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the bugfixes/no-duplicate-decl branch 7 times, most recently from 24244ea to 6728195 Compare January 23, 2024 11:26
Just like GCC, Clang, or Visual Studio we should reject duplicate
declarations of local variables in the same scope.

Fixes: diffblue#8129
@tautschnig tautschnig force-pushed the bugfixes/no-duplicate-decl branch from 6728195 to e466dbe Compare January 23, 2024 11:51
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79fafbe) 79.69% compared to head (e466dbe) 79.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8160   +/-   ##
========================================
  Coverage    79.69%   79.69%           
========================================
  Files         1680     1680           
  Lines       195167   195174    +7     
========================================
+ Hits        155544   155551    +7     
  Misses       39623    39623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit c266ea3 into diffblue:develop Jan 23, 2024
39 checks passed
@tautschnig tautschnig deleted the bugfixes/no-duplicate-decl branch January 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error/warning on duplicate declaration of local variable
4 participants