Skip to content

Conversation

tautschnig
Copy link
Collaborator

We were missing front-end support for reals and did not consistently support all of integers, naturals, rationals, reals but instead would only handle varying subsets in each place.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jun 11, 2024
@tautschnig tautschnig force-pushed the bugfixes/mathematical-types branch from 34b8cbe to e5a11d2 Compare June 11, 2024 19:53
@tautschnig tautschnig force-pushed the bugfixes/mathematical-types branch from e5a11d2 to 19a8310 Compare September 22, 2025 20:02
@tautschnig tautschnig force-pushed the bugfixes/mathematical-types branch 2 times, most recently from cebcc43 to 9cd88b5 Compare September 23, 2025 15:33
@tautschnig tautschnig force-pushed the bugfixes/mathematical-types branch 2 times, most recently from 667b5f5 to 5a6f0b8 Compare September 23, 2025 18:51
We were missing front-end support for reals and did not consistently
support all of integers, naturals, rationals, reals but instead would
only handle varying subsets in each place.
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 63.53591% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (5f4c82d) to head (9d13355).

Files with missing lines Patch % Lines
src/ansi-c/c_typecast.cpp 57.69% 22 Missing ⚠️
src/solvers/smt2/smt2_conv.cpp 73.23% 19 Missing ⚠️
src/util/real.cpp 45.45% 6 Missing ⚠️
src/util/simplify_expr.cpp 28.57% 5 Missing ⚠️
src/solvers/flattening/boolbv_width.cpp 0.00% 4 Missing ⚠️
src/util/real.h 42.85% 4 Missing ⚠️
src/util/rational_tools.cpp 66.66% 3 Missing ⚠️
src/ansi-c/c_typecheck_type.cpp 75.00% 1 Missing ⚠️
src/util/arith_tools.cpp 50.00% 1 Missing ⚠️
src/util/pointer_offset_size.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8324      +/-   ##
===========================================
+ Coverage    80.43%   80.48%   +0.05%     
===========================================
  Files         1695     1697       +2     
  Lines       208285   208385     +100     
  Branches        73       73              
===========================================
+ Hits        167524   167726     +202     
+ Misses       40761    40659     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants