-
Notifications
You must be signed in to change notification settings - Fork 277
operator== for exprt and bool, int, nullptr_t #8675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8675 +/- ##
===========================================
- Coverage 80.39% 80.38% -0.01%
===========================================
Files 1688 1688
Lines 207387 207420 +33
Branches 73 73
===========================================
+ Hits 166728 166738 +10
- Misses 40659 40682 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3179414
to
98ed937
Compare
Introduces comparison operators for more concise code, and deprecates `exprt::is_{true,false,zero,one}` in favour of these.
This provides access to methods that may eventually become private.
Replaces uses of `is_true` and `is_false`.
Avoids use the newly deprecated exprt method.
Avoids use the newly deprecated exprt method.
98ed937
to
1770dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the contract module LGTM.
Introduces comparison operators for more concise code, and deprecates
exprt::is_{true,false,zero,one}
in favour of these.Please review commit-by-commit.