BMC: reconsider lasso-shaped encodings #1202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
bmc-F-encoding
branch
13 times, most recently
from
657edef to
f64a958
Compare
kroening
changed the title
F
kroening
force-pushed
the
bmc-F-encoding
branch
5 times, most recently
from
9fb11a8 to
b043366
Compare
tautschnig
reviewed
Aug 4, 2025
src/smvlang/smv_typecheck.cpp
Outdated
Comment on lines
1950
to
1959
| if(var.type.id() == "submodule") | ||
| { | ||
| symbol.is_input = false; | ||
| symbol.is_state_var = false; | ||
| } | ||
| else | ||
| { | ||
| symbol.is_input = true; | ||
| symbol.is_state_var = false; | ||
| } |
There was a problem hiding this comment.
This change requires git conflict resolution, but also I am confused by the change itself: is_state_var is false in both branches and was set to false before already.
kroening
force-pushed
the
bmc-F-encoding
branch
from
b043366 to
d4f698b
Compare
This replaces the lasso-shaped encodings in the word-level BMC property encoding. The lasso and straigth-line encodings are now built as separate obligations. In the lasso encoding, all operators follow the same lasso shape. This avoids spurious traces where the eventually operator follows the lasso but a safety part of the property does not.
kroening
force-pushed
the
bmc-F-encoding
branch
from
d4f698b to
a3f39b8
Compare
tautschnig
approved these changes
Aug 4, 2025
| symbol.is_state_var = false; | ||
| symbol.value = nil_exprt{}; |
There was a problem hiding this comment.
This line and the one above aren't actually necessary, the symbolt constructor will have set these already. (Though lines 1973 and 1975 should then also be removed.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the lasso-shaped encodings in the word-level BMC property encoding. The lasso and straigth-line encodings are now built as separate obligations. In the lasso encoding, all operators follow the same lasso shape. This avoids spurious traces where the eventually operator follows the lasso but a safety part of the property does not.