Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement binary selfie methods in Python #496

Merged
merged 30 commits into from
Dec 13, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Implements the missing methods in BinarySelfie class to match the Kotlin implementation.

  • Added to_be_base64 and to_be_file methods with proper error handling
  • Added corresponding TODO variants with readonly mode checks
  • Added comprehensive tests matching Kotlin test coverage
  • Follows error handling patterns from Kotlin implementation

Link to Devin run: https://app.devin.ai/sessions/c4005064a2304da5afc5b3946ad8f7a1

devin-ai-integration bot and others added 4 commits December 12, 2024 18:55
- Implemented to_be_base64 and to_be_file methods
- Added corresponding TODO variants with readonly mode checks
- Added comprehensive tests matching Kotlin implementation
- Follows error handling patterns from Kotlin implementation

Co-Authored-By: [email protected] <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

devin-ai-integration bot and others added 25 commits December 12, 2024 20:51
- Use os.path.join for platform-agnostic path joining
- Use os.path.normpath for path normalization
- Maintain forward slash normalization for internal storage
- Update path resolution in resolve_file and resolve_folder methods

Co-Authored-By: [email protected] <[email protected]>
@nedtwigg nedtwigg merged commit b6bdd16 into main Dec 13, 2024
8 checks passed
@nedtwigg nedtwigg deleted the devin/1734028827-implement-binary-selfie branch December 13, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant