-
Notifications
You must be signed in to change notification settings - Fork 490
Add step to forbid module imports #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
If you want to fix other things: the test-case for |
|
thanks for update and kind offer, for me both fine, it seems tiny. Let ned or someone else make the call, my opinion obsolete. |
it would be great to fix that in this PR also, thanks for the offer! An update to the README would be great too. One smell here is that this is a very small change but our standard protocols make it require a ton of code churn. I'm happy to merge this one, but I don't want to merge a ton of |
|
@claude merge |
As per #2679, I added a formatter to forbid module imports.