-
Couldn't load subscription status.
- Fork 5
test: copy_examples test
#65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@sbillinge ready for review |
|
Looks good as long as all the edits were brought over correctly! |
|
@sbillinge compared them side-by-side and the two PRs are the same |
|
Let's then implement the method |
|
@sbillinge ready for review. All tests pass except one that captures the bad output. Im still figuring out how to capture the statement, but wanted to make a push so you can leave comments on function styling and such |
| self, | ||
| examples_to_copy: List[str], | ||
| target_dir: Path = None, | ||
| force: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new force input param
|
I've included a test for the forced overwrite copy of examples. |
|
this still seems to be failing tests |
| for ex_name, ex_path in examples: | ||
| self._copy_tree_to_target(pack_name, ex_name, ex_path) | ||
|
|
||
| def _copy_example(self, example_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name is similar to the copy_examples fucntion except its private and doesnt have an extra s. I left it because its a private function, but let me know if you think we should rename it.
|
@sbillinge Pytest is passing locally now but this is failing CI for some reason. I'm trying to debug on my fork cadenmyers13#8 and I can't quite figure out whats going on. There is a shell script that runs ( @Tieqiong Do you know what might be causing this? FYI, I forgot to pull from upstream before creating this branch so i had to merge the python 3.14 support 🤦♂️ |
|
@cadenmyers13 seems like tests for srreal and pyobjcryst didn't run, probably not compatible with python 3.14 resulting in installation issue. You can see the test env runs on 3.14, which roots from recent 3.14 update on |
|
We also are out of free credits. Even though CMI is open software, it turns out Mac and Windows builds are not free even then, and CMI running all it's examples burned through our allocation. This is also causing tests to fail, at least the merge to main tests |
cleaned up version of this PR: #60