Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

cleaned up version of this PR: #60

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review

@sbillinge
Copy link
Contributor

Looks good as long as all the edits were brought over correctly!

@cadenmyers13
Copy link
Contributor Author

@sbillinge compared them side-by-side and the two PRs are the same

@sbillinge
Copy link
Contributor

Let's then implement the method

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. All tests pass except one that captures the bad output. Im still figuring out how to capture the statement, but wanted to make a push so you can leave comments on function styling and such

self,
examples_to_copy: List[str],
target_dir: Path = None,
force: bool = False,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new force input param

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Oct 23, 2025

I've included a test for the forced overwrite copy of examples.

@sbillinge
Copy link
Contributor

this still seems to be failing tests

for ex_name, ex_path in examples:
self._copy_tree_to_target(pack_name, ex_name, ex_path)

def _copy_example(self, example_name):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name is similar to the copy_examples fucntion except its private and doesnt have an extra s. I left it because its a private function, but let me know if you think we should rename it.

@cadenmyers13
Copy link
Contributor Author

@sbillinge Pytest is passing locally now but this is failing CI for some reason. I'm trying to debug on my fork cadenmyers13#8 and I can't quite figure out whats going on. There is a shell script that runs (requirements/packs/scripts/_pytest.sh) and it calls tar_url.txt which contains this

https://github.com/diffpy/diffpy.srreal/archive/refs/tags/1.4.0.tar.gz
https://github.com/diffpy/diffpy.srfit/archive/refs/tags/3.2.0.tar.gz
https://github.com/diffpy/pyobjcryst/archive/refs/tags/2025.1.0.tar.gz
https://github.com/diffpy/diffpy.structure/archive/refs/tags/3.3.1.tar.gz
https://github.com/Tieqiong/diffpy.utils/archive/refs/tags/3.6.2-rc.0.tar.gz

@Tieqiong Do you know what might be causing this?

FYI, I forgot to pull from upstream before creating this branch so i had to merge the python 3.14 support 🤦‍♂️

@Tieqiong
Copy link
Contributor

Tieqiong commented Oct 29, 2025

@cadenmyers13 seems like tests for srreal and pyobjcryst didn't run, probably not compatible with python 3.14 resulting in installation issue. You can see the test env runs on 3.14, which roots from recent 3.14 update on release-scripts/.github/workflows/_tests-on-pr.yml.
Not quite sure about the ones that got successfully tested though, they are supposed to support only up to 3.13 ... Let's try to add python_version: 3.13 in the test-on-pr workflow for now and see if it passes for now!

@sbillinge
Copy link
Contributor

We also are out of free credits. Even though CMI is open software, it turns out Mac and Windows builds are not free even then, and CMI running all it's examples burned through our allocation. This is also causing tests to fail, at least the merge to main tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants