Skip to content

estimate mu*D from z-scan file #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 14, 2024
Merged

estimate mu*D from z-scan file #101

merged 14 commits into from
Sep 14, 2024

Conversation

yucongalicechen
Copy link
Collaborator

@yucongalicechen yucongalicechen commented Sep 11, 2024 •
edited
Loading

  • closes estimate mud from z-scan file #100
  • added the function for computing mud in a new module and relevant test functions
  • added an optional argument that takes in a z-scan file and a function in tools.py to process that file and update mud
  • I did this in one setting so I put all work in one PR, but I can split into multiple PRs if that's easier to review!

@sbillinge
Copy link
Contributor

@yucongalicechen this has conflicts that need resolving

@yucongalicechen
Copy link
Collaborator Author

@yucongalicechen this has conflicts that need resolving

Okay, I resolved the conflicts. It is ready for review now.

@sbillinge sbillinge merged commit 89c1322 into diffpy:main Sep 14, 2024
3 checks passed
@yucongalicechen yucongalicechen deleted the mud branch September 25, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

estimate mud from z-scan file
2 participants
@yucongalicechen @sbillinge