Skip to content

feat: use hessian in optimization #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

john-halloran
Copy link

A hessian was the one feature I had left out of the original port because I was having issues with it, but as I go on I've realized that it's not optional. Without it, there is too much instability to write reliable tests. Those are ongoing, by the way, but I wanted to open this PR in the meantime.

@sbillinge
Copy link
Contributor

its very hard for me to review this as I am really hazy about what is going on. I am happy to trust you on this. Just let me know if you want it merged.

@john-halloran
Copy link
Author

To be honest, I am hazy on the mathematical details as well. I did some pretty thorough checks, printing out matrices at each step of the process to make sure that they match the MATLAB, but I feel a little out of my depth, especially when it comes to resolving some of the remaining discrepancies that I've noticed. Do you know anyone who could be reached out to so we can give the code a second look?

@sbillinge
Copy link
Contributor

I think if you are able to print out matrices and check htey are the same as the matlab code, it is already rather careful. We could, if we want, capture these as tests. Place the matlab matrix as expected and the matrix produced by your function as actual. That means that this hard work survives into the future and keeps working for us.

At the end we can ask Ran to look it over, but he is not a Python person so he won't give programming insights, but he will have some idea if it is working ok on a larger scale.

@john-halloran
Copy link
Author

Closing for now because this is not the right branch.

@john-halloran john-halloran deleted the tests branch July 22, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants