Skip to content

Conversation

@zmx27
Copy link
Contributor

@zmx27 zmx27 commented Oct 28, 2025

Closes #18

@zmx27
Copy link
Contributor Author

zmx27 commented Oct 28, 2025

@sbillinge ready for review. After removing all noqas, pre-commit still passes:

check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
check for merge conflicts................................................Passed
check toml...............................................................Passed
check for added large files..............................................Passed
black....................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
nbstripout...........................................(no files to check)Skipped
Prevent Commit to Main Branch............................................Passed
codespell................................................................Passed
prettier.................................................................Passed
docformatter.............................................................Passed

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.00%. Comparing base (d278a95) to head (bfd86da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           2        2           
  Lines          18       18           
=======================================
  Hits            9        9           
  Misses          9        9           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see comment

rcParams["backend"] = "Qt4Agg"
try:
import PySide # noqa: F401
importlib.import_module("PySide")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks to me like legacy py2 or earlier python versions. Can we get rid of this logic and just import latest versions of things at the top? We are just supporting 3.11 - 3.13 (initially) then 2.12-3.14 later

@@ -1,24 +1,17 @@
from functools import partial
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I changed this file is that I removed the PySide import and just setting rcParams to QtAgg to allow matplotlib to detect the version of pyside to use (PySide6 or PySide2). I also put all of these matplotlib imports inside the try block, as the presence of mplenabled tells me that matplotlib and PySide are optional dependencies and do not necessarily have to be installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: try and remove all noqa's after packaging

2 participants