Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports view components of the react lazy type #86

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

BroKun
Copy link
Member

@BroKun BroKun commented Dec 10, 2024

No description provided.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: b0dfb00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@difizen/babel-preset-mana Patch
@difizen/mana-observable Patch
@difizen/umi-plugin-mana Patch
@difizen/mana-syringe Patch
@difizen/mana-common Patch
@difizen/mana-react Patch
@difizen/mana-react-example Patch
@difizen/mana-core Patch
@difizen/mana-l10n Patch
@difizen/mana-app Patch
@difizen/mana-umi-example Patch
@difizen/mana-ui Patch
@difizen/mana-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:12am

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 37.93103% with 54 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (3e6b20a) to head (b0dfb00).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/mana-core/src/view/view-container.tsx 8.51% 43 Missing ⚠️
packages/mana-core/src/view/decorator.ts 72.72% 9 Missing ⚠️
packages/mana-core/src/view/utils.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   52.98%   52.93%   -0.05%     
==========================================
  Files         368      369       +1     
  Lines       44163    44389     +226     
  Branches     1005     1624     +619     
==========================================
+ Hits        23399    23497      +98     
- Misses      20764    20892     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant