Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Operators] Fix #43 - Improved exploit max length for dangling operator #44

Closed
wants to merge 2 commits into from

Conversation

falcaopetri
Copy link
Contributor

This PR implements the modification proposed in #43. I've updated all mining assistants that I could find in master.

This PR would also benefit assistants on other branches (such as the Injective assistant).

I've run some basic tests with -maxad 3 and -maxad 4, comparing mined rules before and after this patch. TSVRuleDiff reports no difference between mined rules.

I can see a performance improvement (though I did not benchmark it).
AMIE queue calls to the last generation drops by about half.

@falcaopetri
Copy link
Contributor Author

falcaopetri commented Sep 14, 2020

The new commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant