-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix date time and complex datation validations #20
base: development
Are you sure you want to change the base?
fix date time and complex datation validations #20
Conversation
<% if field.editor_component.present? %> | ||
<% @item.errors.where(field.uuid).each do |error| %> | ||
<div class="base-errors"><%= error.message %></div> | ||
<% end %> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je penses qu'il serait judicieux de déplacer cela dans les 2 components concernées (date et datation) car finalement ces spécifiques a ces 2 components ET l'erreur doit etre dans le form-group
et non pas après.
D'ailleurs ca devrait afficher une double erreur sur un field "classique" non ? As-tu testé ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
la condition if field.editor_component.present?
vérifie si c'est un composant react donc pas de doublons sinon c'est potentiellement possible de passer les erreurs dans les composants react mais plus compliqué
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je comprends mais il est préférable de passer l'erreur au component car le dom ne va pas la. Au moins essaier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai passé l'erreur au composant react
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah top !
script d'export des records en erreur de validation ( + de 6000 records)