Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Combobox into two components #2832

Open
1 task
mimarz opened this issue Nov 26, 2024 · 1 comment
Open
1 task

Split Combobox into two components #2832

mimarz opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
css @digdir/designsystemet-css ☂️ epic Issues ready react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 26, 2024

Split Combobox into two components.

Reasoning:

  • Reduce code complexity of the component
  • Easier to have best ux for each mode
  • We need different dom structure for each mode to best support screen readers
  • Big changes coming to Combobox aria spec: https://www.w3.org/TR/wai-aria-1.2/#combobox

Notes:

  • New names for the components?
  • For multiple select, we force users to show selected options close to the input somewhere, either visually "inside" or right above input. This is important for screen readers
  • Users should be able to choose if datalist should be rendered after input or in a popover
  • If users need to condense multiple select, we will provide examples
  • Check against issues and bugs in Combobox  #2610

Tasks

Preview Give feedback
  1. react
    Barsnes eirikbacker
@mimarz mimarz added css @digdir/designsystemet-css react @digdir/designsystemet-react ☂️ epic Issues ready labels Nov 26, 2024
@mimarz mimarz moved this to 🔵 Inbox in Team Design System Nov 26, 2024
@mimarz mimarz moved this from 🔵 Inbox to ☂ Todo Epics in Team Design System Nov 26, 2024
@Barsnes Barsnes self-assigned this Nov 26, 2024
@mrosvik
Copy link
Member

mrosvik commented Dec 10, 2024

Suggestion: Can we put all the 3 select-components into a folder in Storybook to make it easier to find?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css @digdir/designsystemet-css ☂️ epic Issues ready react @digdir/designsystemet-react
Projects
Status: ☂ Todo Epics
Development

No branches or pull requests

3 participants