feat(Suggestion): ✨ New component #3032
Conversation
🦋 Changeset detectedLatest commit: 3d17279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
|
changeset? |
mimarz
force-pushed
the
feat-suggestion
branch
from
88dd51e to
8501135
Compare
|
Updated to new version of |
| /** | ||
| * The screen reader announcement for singular suggestion, where %d is the number of suggestions | ||
| * @default '%d forslag' | ||
| */ | ||
| singular?: string; | ||
| /** | ||
| * The screen reader announcement for plural suggestions, where %d is the number of suggestions | ||
| * @default '%d forslag' | ||
| */ | ||
| plural?: string; |
There was a problem hiding this comment.
Why can't these be on Suggestion.List?
There was a problem hiding this comment.
could absolutely be and would be easier, just put it here as it felt natural to group all "config" on same element, but maybe both, and filter should be moved to Suggestion.List? 🤔 you can decide
There was a problem hiding this comment.
Since singular and plural is something you can set on u-datalist by default (though with data attrs), it feels more natural that we also do it that way.
filter is not something you can set on any other element, afaik, so it's fine to leave it where it is, I think
There was a problem hiding this comment.
Cool :) There is some discussion to add filter possibility to native <datalist> so maybe we should move it too? Feel free to do the changes you see fitting and merge whenever :) (I'm busy bee as usual here now 🙊 )
There was a problem hiding this comment.
Since filter is used in both .List and .Input, maybe we should keep it on the root Suggestion?
Barsnes
dismissed
their stale review
changes have been made since this was accepted
|
I have added |
|
Looks to work good here 👍 |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - Rename config option from `--json` to `--config` ([#3012](#3012)) ### Patch Changes - Create & build tokens correctly if support-color is missing ([#3035](#3035)) - Removed predefined `accent` variables added during `tokens build`. Use `data-color` or generated named color variables instead. ([#3041](#3041)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) ### Patch Changes - **Chip**: Make radio and checkbox smaller ([#3039](#3039)) - **ToggleGroup**: Change height to match other form elements ([#3055](#3055)) - Chip: avoid reassigning custom properties ([#3019](#3019)) - **Tabs**: Add overflow-x scroll to tablist ([#3030](#3030)) - **Table**: Use `border-top` in `tbody` ensure prettier tables when no `thead` ([#3020](#3020)) - **Tag**: Set `height` in case it is used in `display: flex` ([#3020](#3020)) - `ds-input` will now by default fill width. ([#3020](#3020)) - **Field**: Move `align-items: start` from `.ds-field` to `align-self: start` on `.ds-input` for easier styling ([#3020](#3020)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) - **ErrorSummary**: Split `.Item` into two components ([#3040](#3040)) - `ErrorSummary.Item` renders a `li` - `ErrorSummary.Link` renders the link - Upgrade to React 19 and other related dependencies ([#2964](#2964)) - **Checkbox**: Rename `validation` to `error` ([#3038](#3038)) - **Radio**: Rename `validation` to `error` ([#3038](#3038)) ### Patch Changes - **ErrorSummary**: Add support for `asChild` ([#3040](#3040)) - fix: Use correct DOM property for Popover API when used in React 19 ([#3010](#3010)) ## @digdir/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#2832 #2610
resolves #2882