Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review React props again to make sure they are consistent #2902

Closed
mimarz opened this issue Dec 16, 2024 · 0 comments · Fixed by #3038
Closed

Review React props again to make sure they are consistent #2902

mimarz opened this issue Dec 16, 2024 · 0 comments · Fixed by #3038
Assignees
@Barsnes
Labels
react @digdir/designsystemet-react
Milestone
V1 - Lansering

Comments

@mimarz
Copy link
Collaborator

mimarz commented Dec 16, 2024 •
edited by mrosvik
Loading

Review React props again to make sure they are consistent across components.

Found some inconsistencies when testing our React components.

  • Textfield uses error prop as message passed to <ValidationMessage>, while Radio & Checkbox uses validationMessage prop for the same behaviour.

Related to: #2932
@mimarz mimarz converted this from a draft issue Dec 16, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Dec 16, 2024
@mimarz mimarz changed the title Check consistent React props again Review React props again to make sure they are consistent Dec 16, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Jan 3, 2025
@Barsnes Barsnes mentioned this issue Jan 22, 2025
Merged
@Barsnes Barsnes moved this from 📄 Todo to 🏗 In progress in Team Design System Jan 22, 2025
@Barsnes Barsnes moved this from 🏗 In progress to 👀 Ready for review in Team Design System Jan 23, 2025
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Barsnes Barsnes

Labels
react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
V1 - Lansering
Development

Successfully merging a pull request may close this issue.

chore: go over react props and jsdoc digdir/designsystemet
3 participants
@mimarz @mrosvik @Barsnes