chore: go over react props and jsdoc #3038
Conversation
|
Preview deployments for this pull request: Storybook - |
🦋 Changeset detectedLatest commit: e21ec0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Burde vi brukt jsdoc for å dokumentere når barn skal være en bestemt sub-component? F.eks forventning at ToggleGroup sin children er forventet å være ToggleGroup.Item eller Tabs skal ha Tabs.List og Tabs.Panel.
Det vil indirekte løst forvirring med Alert props tabellen #2760
Dette kunne vi løst i egen PR da. Hva tenker du?
Eg tenker me kan ta det i eigen PR ja :) |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - Rename config option from `--json` to `--config` ([#3012](#3012)) ### Patch Changes - Create & build tokens correctly if support-color is missing ([#3035](#3035)) - Removed predefined `accent` variables added during `tokens build`. Use `data-color` or generated named color variables instead. ([#3041](#3041)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) ### Patch Changes - **Chip**: Make radio and checkbox smaller ([#3039](#3039)) - **ToggleGroup**: Change height to match other form elements ([#3055](#3055)) - Chip: avoid reassigning custom properties ([#3019](#3019)) - **Tabs**: Add overflow-x scroll to tablist ([#3030](#3030)) - **Table**: Use `border-top` in `tbody` ensure prettier tables when no `thead` ([#3020](#3020)) - **Tag**: Set `height` in case it is used in `display: flex` ([#3020](#3020)) - `ds-input` will now by default fill width. ([#3020](#3020)) - **Field**: Move `align-items: start` from `.ds-field` to `align-self: start` on `.ds-input` for easier styling ([#3020](#3020)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) - **ErrorSummary**: Split `.Item` into two components ([#3040](#3040)) - `ErrorSummary.Item` renders a `li` - `ErrorSummary.Link` renders the link - Upgrade to React 19 and other related dependencies ([#2964](#2964)) - **Checkbox**: Rename `validation` to `error` ([#3038](#3038)) - **Radio**: Rename `validation` to `error` ([#3038](#3038)) ### Patch Changes - **ErrorSummary**: Add support for `asChild` ([#3040](#3040)) - fix: Use correct DOM property for Popover API when used in React 19 ([#3010](#3010)) ## @digdir/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
resolves #2902
resolves #2932
What has been done:
export *, and useObject.assignerror, notvalidation. TheValidationMessagecan not be changed away fromdanger