Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small accessibility enhancement on our Storefront #3317

Closed
7 tasks done
Febakke opened this issue Mar 5, 2025 · 1 comment · Fixed by #3323
Closed
7 tasks done

Small accessibility enhancement on our Storefront #3317

Febakke opened this issue Mar 5, 2025 · 1 comment · Fixed by #3323
Assignees
Labels
♿️ accessibility Issues related to accessibility

Comments

@Febakke
Copy link
Member

Febakke commented Mar 5, 2025

A collection of small fixes.

  • Image has alt: image on this page Can add alt text: "Skjermbilde som viser hvor i Figmas grensesitt du kan kjøre Navs plugin for å oppdatere ikonene"
  • Language on code examples 🤔 Not sure what we should do with this. They are often a combination of english and norwegian. Investigate this one more.
  • Same link text different URL Blog article , pattern article on form validation) and pattern article on system alers All of them are Github links. They should have different link texts.
  • Same link texts on our page about design principles. Designprinsiper and design principles are recuring multiple times
  • Links with target='_blank' (Open in new tab) go trough and remove or add text in link where appropriate. Example from Dette kommer i V1 This link and text is a little outdated as well.

Image

@Febakke Febakke added the ♿️ accessibility Issues related to accessibility label Mar 6, 2025
@mimarz mimarz moved this from 🔵 Inbox to 📋 Backlog in Team Designsystemet Mar 6, 2025
@Barsnes Barsnes self-assigned this Mar 6, 2025
@Barsnes Barsnes moved this from 📋 Backlog to 🏗 In progress in Team Designsystemet Mar 6, 2025
@Barsnes
Copy link
Member

Barsnes commented Mar 7, 2025

Language on code examples 🤔 Not sure what we should do with this. They are often a combination of english and norwegian. Investigate this one more.

We will keep our no language, since any programming language is the same in different languages. Text we write ourselves should be norwegian.

@Barsnes Barsnes moved this from 🏗 In progress to 👀 Ready for review in Team Designsystemet Mar 7, 2025
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Designsystemet Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ accessibility Issues related to accessibility
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants