Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storefront): Add caption to Image component #1457

Merged
merged 3 commits into from
Feb 1, 2024
Merged

feat(storefront): Add caption to Image component #1457

merged 3 commits into from
Feb 1, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Feb 1, 2024

As discussed on slack, we need to have a caption under some images

@Barsnes Barsnes marked this pull request as ready for review February 1, 2024 08:05
@Barsnes Barsnes requested a review from mimarz as a code owner February 1, 2024 08:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

Preview deployments for this pull request:

🖥 Storefront 1. Feb 2024 - 15:15 (Norwegian time)

See all deployments at https://dev.designsystemet.no

mimarz
mimarz approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit 0de33d3 into main Feb 1, 2024
3 checks passed
@Barsnes Barsnes deleted the storefront/image-caption branch February 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz