-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minimize css custom property reassignment pt 1 #3043
base: next
Are you sure you want to change the base?
fix: minimize css custom property reassignment pt 1 #3043
Conversation
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File CoverageNo changed files found. |
Input, radio, checkbox still works fine with forced colors |
Thanks for good testing @Barsnes! |
--ds-internal-
for internal CSS custom properties - should we do this? 🤔button
has re-assignments due todata-variant
- should we have more CSS props for this then?data-color
is defined in compontent CSS file, still have re-assignmentsalert
,badge
,button
,card
,details
,link
,popover
,validation
surface
exists aswhite
, so lets deal with these re-assignments after surface is done