Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add code conventions #3044

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from
Draft

docs: add code conventions #3044

wants to merge 4 commits into from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 23, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bcae43a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 24. Jan 2025 - 09:06

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.48% 2958 / 5531
🔵 Statements 53.48% 2958 / 5531
🔵 Functions 85.71% 180 / 210
🔵 Branches 76.69% 520 / 678
File CoverageNo changed files found.
Generated in workflow #1774 for commit bcae43a by the Vitest Coverage Report Action

mimarz
mimarz reviewed Jan 24, 2025
View reviewed changes
packages/css/CODE_CONVENTION.md
Comment on lines +11 to +12
- Only use `background` not `background-color`
- Set border with at least two properties, `border` and `border-color`
Copy link
Collaborator

@mimarz mimarz Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rethink this to split them into three variables? Because of edge-cases such as in #3049

We should add an entry about use of shorthands, because we have encountred pitfalls with both font and now border

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz left review comments

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker will be requested when the pull request is marked ready for review eirikbacker is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz