Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: understanding the color scale #3218

Draft
wants to merge 12 commits into
base: next
Choose a base branch
from
Draft

chore: understanding the color scale #3218

wants to merge 12 commits into from

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Feb 25, 2025 •
edited by mrosvik
Loading

Resolves #2107

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2aa893

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 12. Mar 2025 - 09:52

Storefront - 12. Mar 2025 - 09:53

Theme - 12. Mar 2025 - 09:53

@mimarz mimarz added the post-v1 temporary label for issues/pr after v1 release label Feb 27, 2025
mimarz
mimarz requested changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest on change. I can help out if the feedback was unclear :)

apps/storefront/app/grunnleggende/designelementer/farger/page.mdx Outdated
Comment on lines 73 to 90
| Navn | Bruksområde |
| ----------- | ----------- |
| 1. Background default | Standard bakgrunnsfarge. |
| 2. Background tinted | Bakgrunn med et hint av farge i seg. |
| 3. Surface default | Standard farge for overflater / komponenter. |
| 4. Surface tinted | Overflater / komponenter med et hint av farge i seg. |
| 5. Surface hover | Hover-farge til overflater / komponenter. |
| 6. Surface active | Active-farge til overflater / komponenter. |
| 7. Border subtle | Border-farge med lav kontrast til dekorativ bruk (skillelinjer). |
| 8. Border default | Standard border-farge til skjemakomponenter og meningsbærende elementer. |
| 9. Border strong | Border-farge med høy kontrast for ekstra synlighet. |
| 10. Text subtle | Tekst- og ikonfarge med lavere kontrast. |
| 11. Text default | Tekst- og ikonfarge med høy kontrast og god synlighet. |
| 12. Base default | Standardfarge for solide bakgrunner. |
| 13. Base hover | Hover-farge for solide bakgrunner. |
| 14. Base active | Active-farge for solide bakgrunner. |
| 15. Base contrast subtle | Farge med god kontrast mot Base default. |
| 16. Base contrast default | Farge med god kontrast mot Base default og Base hover. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we create a simple component for this information that uses the colorMetadata its important to make sure this data is correct across multiple apps.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.55% 3250 / 6694
🔵 Statements 48.55% 3250 / 6694
🔵 Functions 82.69% 215 / 260
🔵 Branches 77.6% 558 / 719
File CoverageNo changed files found.
Generated in workflow #2444 for commit b2aa893 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz requested changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes will be requested when the pull request is marked ready for review Barsnes is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker will be requested when the pull request is marked ready for review eirikbacker is a code owner

@oddvernes oddvernes Awaiting requested review from oddvernes oddvernes will be requested when the pull request is marked ready for review oddvernes is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
post-v1 temporary label for issues/pr after v1 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Understanding the color scale
2 participants
@Thunear @mimarz