style(Card): fix default background color token #3331
Conversation
🦋 Changeset detectedLatest commit: 53ab9b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File CoverageNo changed files found. |
packages/css/src/card.css
Outdated
| @@ -27,7 +27,7 @@ | |||
| text-align: inherit; | |||
|
|
|||
| &[data-variant='default'] { | |||
| --dsc-card-background: var(--ds-color-background-default); | |||
| --dsc-card-background: var(--ds-color-surface-default); | |||
There was a problem hiding this comment.
Do we need &[data-variant='default'] { at all when the tokens are the same? I think this is a remainder from the time where we did not have "tinted"
There was a problem hiding this comment.
Is it not best practice to just have both? Without, data-variant="default" will not be selected and just default to default variable for --dsc-card-background.
Hmm this reminds me, what happens if users manually overrides --dsc-card-background and enables data-variant, I guess it wont work due to layers and specificity 🤔
There was a problem hiding this comment.
We had a short huddle and decided to make a separate issue on superflous selectors.
fixes #3334