chore(apps): updates to disabled sb a11y tests #3344
Draft
+4
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3245
I do not get any violations if I re-enable
aria-allowed-attr
rule, so I have removed this.The "combobox role not allowed on input" problem in
Suggestion
/Multisuggestion
seems to possibly stem from this reported issue in axe-core.Specifically this check in implicit-html-roles.js
suggestionsSourceElement = listElement && listElement.nodeName.toLowerCase() === 'datalist';
In our code this returns
u-datalist
.Then in get-element-unallowed-roles.js there is now a mismatch between explicit and implicit role returning false for
roleIsAllowed
If I change the element to
datalist
inSuggestionList.tsx
I no longer get the violation in storybook.Conclusion: it should fix itself in a future update of
@storybook/addon-a11y
after the axe-core issue linked above has been resolved and published