Eliminate double eval from xtmtest and xtmtest-compile #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an xtmtest-with-fixture macro that sets up a fixture and then runs its body in the fixture's environment. There's a bunch of stuff introducing conveniently named macros within the body, which got added as I was debugging and getting the basic macro to work and it's a tad tricky to unpick this and present it as a series of patches adding small pieces of behaviour every time. Sorry.
I thought, I'll fix the double eval in xtmtest and xtmtest-compile by checking if the `form` argument is quoted, stripping the quote, and then doing `(eval ',form (interaction-environment))` in the body of the test. By my understanding of the way lisps work, this should not change behaviour in any way. Hah! Tests are now failing. What on _earth_ am I doing wrong? squash! Fail a sanity check
We're still doing a double eval, but that's only until we fix the tests.
Since we've removed the double eval from xtmtest and xtmtest-compile, we can now fix all the tests to stop quoting their 'form' arguments. 'tests/all-core.xtm' is still passing.
Since we've fixed the tests so they don't quote the 'form' argument, we can remove the belt and braces code that unquoted such forms before expanding the test macros as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #385 for the 'why' of this. This pull requests removes the double evaluation weirdness from
xtmtestandxtmtest-compileand removes the 'just quote theformargument' workaround from the tests.The docs will need updating to reflect that it's no longer necessary to quote the
bind-funcfunc when callingxtmtest.