Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add file descriptor pool to storage #123

Merged
merged 5 commits into from
Jul 13, 2023
Merged

fix: Add file descriptor pool to storage #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f84ae0
fix: Add file descriptor pool to storage
gmaclennan Jul 13, 2023
dec316d
sanity check - why do tests pass in windows?
gmaclennan Jul 13, 2023
a8032a6
Revert "sanity check - why do tests pass in windows?"
gmaclennan Jul 13, 2023
4b7aab3
add explanation of iterator in comment
gmaclennan Jul 13, 2023
7bdda57
Update tests/core-manager.js
gmaclennan Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/core-manager/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class CoreManager extends TypedEmitter {
projectKey,
projectSecretKey,
encryptionKeys = {},
storage
storage,
}) {
super()
assert(
Expand Down
30 changes: 30 additions & 0 deletions lib/core-manager/random-access-file-pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/**
* File descriptor pool for random-access-storage to limit the number of file
* descriptors used. Important particularly for Android where the hard limit for
* the app is 1024.
*/
export class RandomAccessFilePool {
/** @param {number} maxSize max number of file descriptors to use */
constructor (maxSize) {
this.maxSize = maxSize
/** @type {Set<import('random-access-file')>} */
this.active = new Set()
}

/** @param {import('random-access-file')} file */
_onactive (file) {
if (this.active.size >= this.maxSize) {
// suspend least recently inserted this manually iterates in insertion
// order, but only iterates to the first one (least recently inserted)
const toSuspend = this.active[Symbol.iterator]().next().value
toSuspend.suspend()
this.active.delete(toSuspend)
}
this.active.add(file)
}

/** @param {import('random-access-file')} file */
_oninactive (file) {
this.active.delete(file)
}
}
172 changes: 155 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@
"eslint-config-prettier": "^8.8.0",
"nanobench": "^3.0.0",
"prettier": "^2.8.8",
"random-access-file": "^4.0.4",
"random-access-memory": "^6.2.0",
"rimraf": "^5.0.0",
"tempy": "^3.1.0",
"ts-proto": "^1.147.1",
"type-fest": "^3.10.0",
"typedoc": "^0.24.6",
Expand All @@ -69,7 +71,7 @@
"b4a": "^1.6.3",
"base32.js": "^0.1.0",
"better-sqlite3": "^8.3.0",
"corestore": "^6.5.2",
"corestore": "^6.8.4",
"hypercore": "^10.9.0",
"hypercore-crypto": "^3.3.1",
"hyperdrive": "^11.0.0-alpha.10",
Expand Down
Loading