chore: fix type errors in bitfield-rle tests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all the type errors in the tests for `bitfield-rle`. Some of the type errors were entirely test-only, but others required changes to the "real" code. Most notably, many `Buffer` types were changed to `Uint8Array`, and some unused code was removed.
EvanHahn
force-pushed
the
bitfield-rle-type-fixes
branch
from
4b16cd4 to
c66fba7
Compare
EvanHahn
commented
May 7, 2024
gmaclennan
reviewed
May 17, 2024
|
I redid this to limit source changes.
|
gmaclennan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the type errors in the tests for
bitfield-rle. Some of the type errors were entirely test-only, but others required changes to the "real" code. Most notably, manyBuffertypes were changed toUint8Array.