Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpm: fix an issue during the 'Verify and install' firmware step #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gpm: fix an issue during the 'Verify and install' firmware step #36

wants to merge 1 commit into from

Conversation

diescalo
Copy link
Member

  • If the connection with the device is Bluetooth, the device could be reset without receiving an ACK when the install firmware API packet is issued on the write characterisitic. This causes an exception different than the expected in the 'Verify and install' firmware step, making the overall process to fail.
  • Issue the 'Verify and install' packet in first instance and send the 'Verify' packet only if the previous one fails and the cause is not a timeout waiting for the answer.

@diescalo
gpm: fix an issue during the 'Verify and install' firmware step
158fcca 
- If the connection with the device is Bluetooth, the device could be reset
  without receiving an ACK when the install firmware API packet is issued
  on the write characterisitic. This causes an exception different than the
  expected in the 'Verify and install' firmware step, making the overall
  process to fail.
- Issue the 'Verify and install' packet in first instance and send the
  'Verify' packet only if the previous one fails and the cause is not a
  timeout waiting for the answer.

Signed-off-by: Diego Escalona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgonzaleDigi hgonzaleDigi hgonzaleDigi approved these changes

@tatianaleon tatianaleon tatianaleon approved these changes

@rubenmoral rubenmoral rubenmoral approved these changes

@daescalona daescalona daescalona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diescalo @daescalona @rubenmoral @tatianaleon @hgonzaleDigi