Skip to content

Commit

Permalink
Merge pull request mvz#226 from mvz/fix-new-rubocop-offenses
Browse files Browse the repository at this point in the history
Update rubocop-rspec and fix new offenses
  • Loading branch information
mvz authored Sep 10, 2023
2 parents db13d6f + b8f701e commit 3bf4278
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Naming/PredicateName:
- 'has_many'
- 'has_xml_content'

RSpec/FilePath:
RSpec/SpecFilePathFormat:
CustomTransform:
HappyMapper: 'happymapper'

Expand Down
2 changes: 1 addition & 1 deletion nokogiri-happymapper.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rubocop", "~> 1.56"
spec.add_development_dependency "rubocop-packaging", "~> 0.5.2"
spec.add_development_dependency "rubocop-performance", "~> 1.19"
spec.add_development_dependency "rubocop-rspec", "~> 2.23"
spec.add_development_dependency "rubocop-rspec", "~> 2.24"
spec.add_development_dependency "simplecov", "~> 0.22.0"
end
8 changes: 4 additions & 4 deletions spec/features/inheritance_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ class Overwrite < Parent

context "when parsing xml" do
it "parses the new overwritten attribut" do
expect(overwrite.love).to be == "love"
expect(overwrite.love).to eq "love"
end

it "parses the new overwritten element" do
expect(overwrite.genetics).to be == 1001
expect(overwrite.genetics).to eq 1001
end
end

Expand All @@ -66,11 +66,11 @@ class Overwrite < Parent
end

it "has only 1 genetics element" do
expect(xml.xpath("//genetics").count).to be == 1
expect(xml.xpath("//genetics").count).to eq 1
end

it "has only 1 love attribute" do
expect(xml.xpath("@love").text).to be == "love"
expect(xml.xpath("@love").text).to eq "love"
end
end
end
Expand Down

0 comments on commit 3bf4278

Please sign in to comment.