-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use safer default for docker port mapping
If the docker port mapping does not use a specific IP, it the port will be opened for all available network devices. This might be potentially dangerous, because people who just quickly want to try out the DVWA are not always aware of this issue. Nevertheless anyone on their local network could then access the DVWA inside the container. Therefore this commit changes the default to be mapped to the same port only on the local loopback device as the safer default, and adds a short explanation in the respectice section in README, so that people can make it available on all network devices, if they really need to.
- Loading branch information
jackie / Andrea Ida Malkah Klaura
committed
Mar 13, 2024
1 parent
9ca729d
commit 14f8e94
Showing
3 changed files
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ services: | |
networks: | ||
- dvwa | ||
ports: | ||
- 4280:80 | ||
- 127.0.0.1:4280:80 | ||
restart: unless-stopped | ||
|
||
db: | ||
|