lint

digio-ch · Sep 11, 2024 · dcd889d · dcd889d
1 parent a22c9af
commit dcd889d
Show file tree

Hide file tree

Showing 14 changed files with 43 additions and 44 deletions.
diff --git a/src/Command/ImportGamificationCommand.php b/src/Command/ImportGamificationCommand.php
@@ -14,7 +14,6 @@
 
 class ImportGamificationCommand extends StatisticsCommand
 {
-
     /** @var EntityManagerInterface $em */
     private EntityManagerInterface $em;
 
@@ -45,7 +44,7 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $start = microtime( true);
+        $start = microtime(true);
         $json = json_decode(file_get_contents($this->pathToJson), true);
 
         $this->em->getConnection()->executeQuery('DELETE FROM gamification_person_profile');
@@ -68,7 +67,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return 0;
     }
 
-    protected function importLevels(array $jsonLevels, OutputInterface $output) {
+    protected function importLevels(array $jsonLevels, OutputInterface $output)
+    {
         foreach ($jsonLevels as $jsonLevel) {
             $level = $this->levelRepository->findOneBy(["key" => $jsonLevel["key"]]);
             if (is_null($level)) {
@@ -90,7 +90,8 @@ protected function importLevels(array $jsonLevels, OutputInterface $output) {
         $this->em->flush();
     }
 
-    protected function importGoals(array $jsonGoals, OutputInterface $output) {
+    protected function importGoals(array $jsonGoals, OutputInterface $output)
+    {
         foreach ($jsonGoals as $jsonGoal) {
             $goal = $this->goalRepository->findOneBy(['key' => $jsonGoal['key']]);
             if (is_null($goal)) {

diff --git a/src/Command/PseudonymizeLoginCommand.php b/src/Command/PseudonymizeLoginCommand.php
@@ -13,7 +13,6 @@
 
 class PseudonymizeLoginCommand extends StatisticsCommand
 {
-
     private LoginRepository $loginRepository;
 
     private float $duration;
@@ -34,8 +33,10 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $start = microtime( true);
-        $pseudonymizedLogins = $this->loginRepository->pseudonymizeAllOlderThan18Months(function ($personId) { return hash('sha256', $personId);}); // sha256 is mostly collision free and currently irreversible, sufficient for our purposes.
+        $start = microtime(true);
+        $pseudonymizedLogins = $this->loginRepository->pseudonymizeAllOlderThan18Months(function ($personId) {
+            return hash('sha256', $personId);
+        }); // sha256 is mostly collision free and currently irreversible, sufficient for our purposes.
         $log = $input->getOption('log');
         if ($log) {
             $output->writeln('Following Logins (id) have been pseudonymized:');

diff --git a/src/Controller/Api/GamificationController.php b/src/Controller/Api/GamificationController.php
@@ -43,33 +43,31 @@ public function postGroupChange(
     public function usedCardLayer(
         Request $request,
         PersonGamificationService $personGamificationService
-    )
-    {
+    ) {
         $personGamificationService->genericGoalProgress($this->getUser(), 'card');
         return new Response('', 200);
     }
 
     public function usedDataFilter(
         Request $request,
         PersonGamificationService $personGamificationService
-    )
-    {
+    ) {
         $personGamificationService->genericGoalProgress($this->getUser(), 'data');
         return new Response('', 200);
     }
 
     public function usedTimeFilter(
         Request $request,
         PersonGamificationService $personGamificationService
-    )
-    {
+    ) {
         $personGamificationService->genericGoalProgress($this->getUser(), 'time');
         return new Response('', 200);
     }
 
-    public function getUserProfile(Request $request,
-        PersonGamificationService $personGamificationService)
-    {
+    public function getUserProfile(
+        Request $request,
+        PersonGamificationService $personGamificationService
+    ) {
         $dto = $personGamificationService->getPersonGamificationDTO($this->getUser(), $request->getLocale());
         return $this->json($dto);
     }

diff --git a/src/DTO/Mapper/GamificationPersonProfileMapper.php b/src/DTO/Mapper/GamificationPersonProfileMapper.php
@@ -9,7 +9,6 @@
 
 class GamificationPersonProfileMapper
 {
-
     public static function createFromEntity(GamificationPersonProfile $profile, string $locale): PersonGamificationDTO
     {
         $dto = new PersonGamificationDTO();
@@ -27,7 +26,8 @@ public static function createFromEntity(GamificationPersonProfile $profile, stri
         return $dto;
     }
 
-    public static function checkLevelUp(GamificationPersonProfile $profile) {
+    public static function checkLevelUp(GamificationPersonProfile $profile)
+    {
         $levelUps = $profile->getPerson()->getLevelUps();
         if (count($levelUps) > 0) {
             return true;

diff --git a/src/DTO/Model/Gamification/GoalDTO.php b/src/DTO/Model/Gamification/GoalDTO.php
@@ -106,5 +106,4 @@ public function setRequired(bool $required): void
     {
         $this->required = $required;
     }
-
 }
diff --git a/src/DTO/Model/Gamification/LevelDTO.php b/src/DTO/Model/Gamification/LevelDTO.php
@@ -90,5 +90,4 @@ public function setGoals(array $goals): void
     {
         $this->goals = $goals;
     }
-
 }
diff --git a/src/DTO/Model/Gamification/PersonGamificationDTO.php b/src/DTO/Model/Gamification/PersonGamificationDTO.php
@@ -90,5 +90,4 @@ public function setLevels(array $levels): void
     {
         $this->levels = $levels;
     }
-
 }
diff --git a/src/Entity/Gamification/GamificationPersonProfile.php b/src/Entity/Gamification/GamificationPersonProfile.php
@@ -74,7 +74,7 @@ class GamificationPersonProfile
      * @ORM\Column(type="boolean")
      */
     private $el_improved;
-    
+
 
     public function getId(): ?int
     {

diff --git a/src/Entity/Gamification/Level.php b/src/Entity/Gamification/Level.php
@@ -197,6 +197,4 @@ public function setKey($key): void
     {
         $this->key = $key;
     }
-
-
 }
diff --git a/src/Repository/Gamification/LoginRepository.php b/src/Repository/Gamification/LoginRepository.php
@@ -25,9 +25,10 @@ public function __construct(ManagerRegistry $registry)
         parent::__construct($registry, Login::class);
     }
 
-    public function findAllActiveBy(array $criteria, array $orderBy = null, $limit = null, $offset = null) {
+    public function findAllActiveBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+    {
         $criteria['hashed_id'] = null;
-        return $this->findBy($criteria,$orderBy, $limit, $offset);
+        return $this->findBy($criteria, $orderBy, $limit, $offset);
     }
 
     /**

diff --git a/src/Repository/Security/PermissionRepository.php b/src/Repository/Security/PermissionRepository.php
@@ -196,6 +196,4 @@ public function endAllOpenPermissions(): void
             ]
         );
     }
-
-
 }
diff --git a/src/Service/Gamification/LoginService.php b/src/Service/Gamification/LoginService.php
@@ -26,15 +26,15 @@ public function __construct(
         LoginRepository $loginRepository,
         GroupRepository $groupRepository,
         PermissionRepository $permissionRepository
-    )
-    {
+    ) {
         $this->personRepository = $personRepository;
         $this->loginRepository = $loginRepository;
         $this->groupRepository = $groupRepository;
         $this->permissionRepository = $permissionRepository;
     }
 
-    public function logByUserDTOForLogin(PbsUserDTO $userDTO):Login {
+    public function logByUserDTOForLogin(PbsUserDTO $userDTO): Login
+    {
         $login = new Login();
 
         $activeGroupDTO = $userDTO->getGroups()[0]; // Group 0 is the active group on Login.
@@ -63,7 +63,8 @@ public function logByUserDTOForLogin(PbsUserDTO $userDTO):Login {
         return $login;
     }
 
-    public function logByPersonAndGroup(PbsUserDTO $userDTO, Group $group) {
+    public function logByPersonAndGroup(PbsUserDTO $userDTO, Group $group)
+    {
         $login = new Login();
         $person = $this->personRepository->find($userDTO->getId());
         $role = $this->permissionRepository->findHighestById($group, $person->getId());

diff --git a/src/Service/Gamification/PersonGamificationService.php b/src/Service/Gamification/PersonGamificationService.php
@@ -43,8 +43,7 @@ public function __construct(
         PersonRepository $personRepository,
         EntityManagerInterface $em,
         LevelUpLogRepository $levelUpLogRepository
-    )
-    {
+    ) {
         $this->loginRepository = $loginRepository;
         $this->levelRepository = $levelRepository;
         $this->personRepository = $personRepository;
@@ -53,7 +52,8 @@ public function __construct(
         $this->levelUpLogRepository = $levelUpLogRepository;
     }
 
-    public function reset(PbsUserDTO $pbsUserDTO) {
+    public function reset(PbsUserDTO $pbsUserDTO)
+    {
         $person = $this->personRepository->find($pbsUserDTO->getId());
         $pgp = $this->getPersonGamification($person);
         $this->personGoalRepository->remove($pgp);
@@ -62,7 +62,7 @@ public function reset(PbsUserDTO $pbsUserDTO) {
     public function getPersonGamification(Person $person): GamificationPersonProfile
     {
         $gamificationProfile = $person->getGamification();
-        if(is_null($gamificationProfile)) {
+        if (is_null($gamificationProfile)) {
             $gamificationProfile = new GamificationPersonProfile();
             $gamificationProfile->setLevel($this->levelRepository->findOneBy(['key' => 0]));
             $gamificationProfile->setPerson($person);
@@ -80,7 +80,8 @@ public function getPersonGamification(Person $person): GamificationPersonProfile
         return $gamificationProfile;
     }
 
-    public function genericGoalProgress(PbsUserDTO $pbsUserDTO, string $type) {
+    public function genericGoalProgress(PbsUserDTO $pbsUserDTO, string $type)
+    {
         $person = $this->personRepository->find($pbsUserDTO->getId());
         $pgp = $this->getPersonGamification($person);
 
@@ -127,7 +128,8 @@ public function genericGoalProgress(PbsUserDTO $pbsUserDTO, string $type) {
         $this->em->flush();
     }
 
-    public function checkLevelUp(GamificationPersonProfile $person) {
+    public function checkLevelUp(GamificationPersonProfile $person)
+    {
         $currentLevel = $person->getLevel();
         $nextLevel = $this->levelRepository->findNextLevel($currentLevel);
 
@@ -178,18 +180,20 @@ public function checkLevelUp(GamificationPersonProfile $person) {
         return $person;
     }
 
-    private function resetLevelUp(Person $person) {
+    private function resetLevelUp(Person $person)
+    {
         $levelUps = $this->levelUpLogRepository->findBy(['person' => $person->getId()]);
         foreach ($levelUps as $levelUp) {
             $this->levelUpLogRepository->remove($levelUp);
         }
     }
 
-    public function checkLoginGoal(GamificationPersonProfile $profile): bool {
+    public function checkLoginGoal(GamificationPersonProfile $profile): bool
+    {
         return count($profile->getPerson()->getLogins()) >= 4;
     }
 
-    public function getPersonGamificationDTO(PbsUserDTO $pbsUserDTO, String $locale): PersonGamificationDTO
+    public function getPersonGamificationDTO(PbsUserDTO $pbsUserDTO, string $locale): PersonGamificationDTO
     {
         $levels = $this->levelRepository->findBy(['type' => Level::USER]);
         /** @var Person $person */

diff --git a/src/Service/Gamification/QuapGamificationService.php b/src/Service/Gamification/QuapGamificationService.php
@@ -13,8 +13,7 @@ class QuapGamificationService
     public function __construct(
         PersonGamificationService $personGamificationService,
         AggregatedQuapRepository $aggregatedQuapRepository
-    )
-    {
+    ) {
         $this->personGamificationService = $personGamificationService;
         $this->aggregatedQuapRepository = $aggregatedQuapRepository;
     }
@@ -62,7 +61,8 @@ public function processQuapEvent(array $newAnswers, Group $group, PbsUserDTO $pb
         }
     }
 
-    private function isQuestionnaireFullyAnswered($questionnaire) {
+    private function isQuestionnaireFullyAnswered($questionnaire)
+    {
         foreach ($questionnaire as $answer) {
             if ($answer === 0) {
                 return false;