Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance for upgrades checking #19859

Open
dylant-da opened this issue Aug 29, 2024 · 2 comments
Open

Performance for upgrades checking #19859

dylant-da opened this issue Aug 29, 2024 · 2 comments
Assignees

Comments

@dylant-da
Copy link
Contributor

When checking modules individually for upgrade validity we re-run the following for each module:

It would be ideal if we could save a lot of effort on each module where possible. This will require a bit of rearchitecting of the upgrade checking logic.

@dylant-da dylant-da self-assigned this Aug 29, 2024
@dylant-da dylant-da changed the title Performance for upgrades per-module checking Performance for upgrades checking Aug 30, 2024
@paulbrauner-da
Copy link
Contributor

Also here, the filter could produce a lazy map that would only test as we iterate over the keys, since we return an error for the first one only.

@dylant-da
Copy link
Contributor Author

dylant-da commented Sep 17, 2024

This'll just be a general ticket in which we track perf issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants