Add code for structural equality, check that keys are upgradeable (2.9.x) #19666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
dylant-da
force-pushed
the
upgrade-checks-disallow-key-upgrades-2.9.x
branch
from
0212e83
to
a1db246
Compare
Refactor to have correct gamma in scope for recursive checks
…ks-disallow-key-upgrades-2.9.x
dylant-da
changed the title
There was a problem hiding this comment.
Generally LGTM but I believe that the type constructor comparison may not always work as intended depending in which order we treat the dependencies.
Maybe that doesn't matter much here as we'd always recheck all packages? I'm not clear on what triggers a comparison at which level.
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
sdk/compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Upgrade.hs
Outdated
Show resolved
Hide resolved
…ks-disallow-key-upgrades-2.9.x
…mplate (#19817) * Forbid adding new interface instances to the upgraded version of a template * allow adding new instances to new templates
…ion of a template (#19820) * [compiler] forbid adding new interface instances to the upgraded version of a template * allow adding new instances to new templates * add two more tests
paulbrauner-da
approved these changes
Sep 2, 2024
| , toListOf (packageRefs . _PRImport) pkg | ||
| ) | ||
| fromPkgNode (x, _pkgId, _deps) = x | ||
| sccs = G.stronglyConnCompR (map toPkgNode pkgs) |
There was a problem hiding this comment.
Maybe mention that stronglyConnCompR also performs a topo sort as a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on work from #19184 and #19509