Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-port assorted participant-side checks & check keys for structural equality 3.x #19691

Closed
wants to merge 17 commits into from
Closed

Forward-port assorted participant-side checks & check keys for structural equality 3.x #19691

wants to merge 17 commits into from

Commits on Jul 30, 2024

  1. Forwardport daml#19392 and canton#19524

    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9dd2bc1 View commit details
    Browse the repository at this point in the history

  2. Cherrypick "upgrades check all packages (#19328)", dupe ValidUpgrade 

    * Upgrades validation for every package in dar

* fix 1.15 error

* transitivity is fine

* remove unnecessary parens/braces as pointed out by IJ + use EitherUtil.IfThenET for consistency

* add tests for dependency upgrade validation

* put back message when skipping validation

* address comments

* comment to address Tudor's comment

---------

Co-authored-by: Samuel Williams <[email protected]>
    @paulbrauner-da @samuel-williams-da @dylant-da
    2 people authored and dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9c3cc45 View commit details
    Browse the repository at this point in the history

  3. Pick "ignore non serializable types during upgrade validation (#19356)" 

    Fixes for interfaces

Co-authored-by: Remy <[email protected]>

---------

Co-authored-by: Remy <[email protected]>
    @paulbrauner-da @remyhaemmerle-da @dylant-da
    2 people authored and dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2aad333 View commit details
    Browse the repository at this point in the history

  4. Pick "Force that upgrading types must belong to identically-named pac… 

    …kages (#19357)"

---------

Co-authored-by: Remy <[email protected]>
    @paulbrauner-da @remyhaemmerle-da @dylant-da
    2 people authored and dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a3f45d0 View commit details
    Browse the repository at this point in the history

  5. Port instance tests (pick some parts of "Backport Dylan's interface u… 

    …pgrade checks (#19380)")
    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    51ef934 View commit details
    Browse the repository at this point in the history

  6. Pick "Ignore "utility packages" in upgrade checks (#19392)" 

    * Add utility package upgrade check

* Add a test that uploading the std lib for 2 different LF versions shouldn't fail

* Fix tests

* Fix invalid package preferences

---------

Co-authored-by: Paul Brauner <[email protected]>
    @samuel-williams-da @paulbrauner-da @dylant-da
    2 people authored and dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3025f23 View commit details
    Browse the repository at this point in the history

  7. Port key upgrade static checks from 2.9 to 2.x (#19565) 

    * Fix key upgrade validation in 2.9 (#19509)

Fix key upgrade validation in 2.9

* Fix key type upgrade check test to a weaker one for compiler-side checks

---------

Co-authored-by: Dylan Thinnes <[email protected]>
    @paulbrauner-da @dylant-da
    paulbrauner-da and dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e7a7815 View commit details
    Browse the repository at this point in the history

  8. lint

    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    de2b321 View commit details
    Browse the repository at this point in the history

  9. Fix MissingModule use of Daml.Script

    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    01e5285 View commit details
    Browse the repository at this point in the history

  10. Move V1 features alongside V2 features inside of LanguageVersion

    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2f70ed3 View commit details
    Browse the repository at this point in the history

  11. lint

    @dylant-da
    dylant-da committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    88c333d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Drop package-name check workaround, use supportsPackageUpgrades

    @dylant-da
    dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a95fbae View commit details
    Browse the repository at this point in the history

  2. [Compiler] types from the non stable part of stdlib are unserialiazab… 

    …le (#19345)

first step to fix #19338
    @remyhaemmerle-da @dylant-da
    remyhaemmerle-da authored and dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f6896af View commit details
    Browse the repository at this point in the history

  3. Ignore numeric for serializability, due to RoundingMode

    @dylant-da
    dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1dc3dda View commit details
    Browse the repository at this point in the history

  4. lint

    @dylant-da
    dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    997e5dd View commit details
    Browse the repository at this point in the history

  5. Re-enable flakiness on daml-lf/validation

    @dylant-da
    dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    40e24aa View commit details
    Browse the repository at this point in the history

  6. Bump

    @dylant-da
    dylant-da committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f16220e View commit details
    Browse the repository at this point in the history