Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Grid Implementation #121

Open
wants to merge 6 commits into
base: v5-alpha
Choose a base branch
from

Conversation

badg0003
Copy link

@badg0003 badg0003 commented Apr 6, 2020

Added CSS Grid for supporting browser and allowed for side-scrolling (native scrollbar, currently) with scroll-snap enabled so it's a clean horizontal scroll.

One minor change was to move the close button for each window into the same container as the text dropdowns so we could avoid having to absolute position it and allow the button to flow a bit better on smaller screens.

Lastly, the selfsame button was converted to a <button> for accessibility (keyboard access, primarily) reasons.

@johndyer
Copy link
Member

johndyer commented Apr 8, 2020

Thanks so much for this! I'll check it out.

Eventually, we'll also need to think about a responsive mode where the windows can stack and be pulled to the front (like the current https://biblewebapp.com/study).

Also the reason why the close button was on top was so that it would also be visible, even if the screen width was too small for the menu controls. But I like this, and it really modernizes and cleans up the code.

@badg0003
Copy link
Author

badg0003 commented Apr 8, 2020

Thanks @johndyer I can take a look at that this week (windows stack on mobile).

One problem I've had is getting the texts to build and show up on my local dev. Is there a proper sequence I should be following when creating my environment?

@johndyer
Copy link
Member

johndyer commented Apr 8, 2020 via email

@badg0003
Copy link
Author

Thanks John. In the meantime I can take a stab at the mobile version. Were you wanting the same UI (tabs) as is on production site?

@johndyer
Copy link
Member

That'd be great. If you have another idea besides using absolute positioning and pseudo elements, I'm all for it!

@badg0003
Copy link
Author

Hi @johndyer I'll have some time this week to implement the revised mobile layout of the tabs. Are you looking for the same design/UX that you have on the current production site or did you have something else in mind?

@johndyer
Copy link
Member

johndyer commented Apr 22, 2020 via email

@KenBitgood
Copy link

KenBitgood commented Apr 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants