Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Create BatchSendingItem endpoint from POST to PUT #267

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

IamDejv
Copy link
Contributor

@IamDejv IamDejv commented Sep 22, 2024

Create Endpoint now overwrite all items in BatchSending

Description

Describe your changes in detail.

Motivation and context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Create Endpoint now overwrite all items in BatchSending
@IamDejv IamDejv self-assigned this Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (106cad9) to head (7254bad).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #267   +/-   ##
=========================================
  Coverage     97.54%   97.54%           
- Complexity      468      469    +1     
=========================================
  Files            74       74           
  Lines          1100     1102    +2     
=========================================
+ Hits           1073     1075    +2     
  Misses           27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelVais PavelVais merged commit bca6e64 into digitalcz:2.x Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants