Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple logging area/task runner #41

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

alexgleith
Copy link
Contributor

Very simple. Just logs things. Doesn't handle errors.

@alexgleith
Copy link
Contributor Author

Closes #9

@jessjaco
Copy link
Collaborator

jessjaco commented Jan 3, 2024

I'm concerned this doesn't support the send_area_to_processor arg of Processor

@alexgleith
Copy link
Contributor Author

I'm concerned this doesn't support the send_area_to_processor arg of Processor

I can add that in. I don't know why it's there is all.

Will add it now.

@jessjaco
Copy link
Collaborator

jessjaco commented Jan 3, 2024

It's there because I use the area in a lot of the processors I write and use. But I don't want to make every processor support an area argument. It does stick out a little, but it's the best option I could come up with.

@alexgleith alexgleith merged commit 7d51a7e into main Jan 3, 2024
@alexgleith alexgleith deleted the add-simple-area-logging-task branch January 3, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants