1853: Fix the style of dialogs in the app #1857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seluianova
requested review from
steffenkleinle,
f1sh1918 and
ztefanie
as code owners
seluianova
commented
Jan 9, 2025
| @@ -44,7 +44,7 @@ | |||
| "limitReached": "Ihr Passlimit wurde erreicht. Bitte entfernen Sie vorher einen Pass, damit Sie einen neuen aktivieren können.", | |||
| "buttonText": "Pass aktivieren", | |||
| "invalidCode": "Ihr Aktivierungscode ist ungültig.", | |||
| "alreadyExists": "Dieser Pass wurde bereits auf dem Gerät aktiviert.", | |||
| "alreadyExists": "Dieser Pass wurde bereits auf diesem Gerät aktiviert.", | |||
There was a problem hiding this comment.
just a small nitpick, it's "this device" in the english version
seluianova
commented
Jan 9, 2025
| controlAffinity: ListTileControlAffinity.leading, | ||
| contentPadding: EdgeInsets.zero, | ||
| visualDensity: VisualDensity.compact, |
There was a problem hiding this comment.
Fixed text size and padding a bit, I think it looks better this way
Before:
After:
There was a problem hiding this comment.
this is the view for the static card verification?
looks good. Just ensure that the cards of other projects still work
There was a problem hiding this comment.
this is the view for the static card verification?
yes
Just ensure that the cards of other projects still work
I checked Nürnberg as well, but feel free to double check
f1sh1918
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Fix styling issues in the dialogs
Proposed changes
Side effects
Couldn't find any
Testing
Check different dialogs in the app (I believe I checked every dialog I touched)
Resolved issues
Fixes: #1853
Fixes: #1846
And some other findings, like