Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2356: Show nearby cities for web #3053

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bahaaTuffaha
Copy link
Contributor

Short description

Showing nearby cities for web.

Proposed changes

  • Created a small component just to show nearby cities similar to groups.
  • Used the getUserLocation() the same way it's been used at PoisPage.tsx.
  • Added some mocks.

Side effects

  • CitySelector.tsx

Testing

  • Change location or http://localhost:9000/landing/en
  • Enable location and refresh the page.
  • If you are not located in Germany you can override you location from F12 -> 3 dots menu -> more tools -> sensors -> change it to Berlin.

Fixes: #2356


@steffenkleinle
Copy link
Member

That was fast! Nice work 🚀

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me 👍
Tested on chrome, safari and firefox

web/src/components/NearbyCities.tsx Outdated Show resolved Hide resolved
web/src/components/NearbyCities.tsx Outdated Show resolved Hide resolved
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on firefox, works great!

web/src/components/CitySelector.tsx Outdated Show resolved Hide resolved
web/src/components/NearbyCities.tsx Outdated Show resolved Hide resolved
web/src/components/NearbyCities.tsx Outdated Show resolved Hide resolved
web/src/components/NearbyCities.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IGAPP-1046: Show nearby cities
3 participants