Skip to content

Commit

Permalink
docs: longer description as per CRAN feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jkennedyie committed Jul 22, 2024
1 parent 0f8c07d commit ec494bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
## Resubmission
This is a resubmission. In this version I have:

* extended the DESCRIPTION description
* made the DESCRIPTION description longer.

* not added any references to DESCRIPTION description as there are no formal references for the conversion this package implements. There is a wikipedia page (https://en.wikipedia.org/wiki/Irish_grid_reference_system) but I prefer not to add a reference to wikipedia. None of the Wikipedia page references formally describe the conversion this package implements either. The conversion is just a sequence of logical steps so nobody has formally described it anywhere.

* used an alternative approach to remove the plot_maps error. It seems that the dynamic chunk eval setting technique I used is not compatible with CRAN automated vignette testing, so I refactored my technique.
* used an alternative approach to remove the plot_maps error. It seems that the dynamic chunk eval setting technique I used was not compatible with CRAN automated vignette testing, so I refactored my technique.

## R CMD check results

Expand Down
2 changes: 1 addition & 1 deletion man/igr-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ec494bb

Please sign in to comment.