Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set GOTOOLCHAIN=local #7

Merged
merged 1 commit into from
Oct 23, 2024
Merged

ci: set GOTOOLCHAIN=local #7

merged 1 commit into from
Oct 23, 2024

Conversation

connorkuehl
Copy link
Collaborator

Newer versions of the Go toolchain may add a toolchain directive to the go.mod. This causes the Go toolchain to download the specified toolchain for interacting with the module. This silently undermines our CI, which builds and tests against 'stable' and 'oldstable' aliases, respectively.

To fix, set GOTOOLCHAIN=local so it always uses the installed version of Go and does not download the version that is specified by the toolchain directive (when it exists.)

https://go.dev/doc/toolchain#GOTOOLCHAIN

Newer versions of the Go toolchain may add a toolchain directive to the
go.mod. This causes the Go toolchain to download the specified toolchain
for interacting with the module. This silently undermines our CI, which
builds and tests against 'stable' and 'oldstable' aliases, respectively.

To fix, set GOTOOLCHAIN=local so it always uses the installed version of
Go and does not download the version that is specified by the toolchain
directive (when it exists.)

https://go.dev/doc/toolchain#GOTOOLCHAIN
@connorkuehl connorkuehl requested a review from a team as a code owner October 18, 2024 17:52
@connorkuehl connorkuehl merged commit 5974853 into main Oct 23, 2024
7 checks passed
@connorkuehl connorkuehl deleted the gotoolchain branch October 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants