Add maintenance day validation for database and kubernetes clusters #1293
Conversation
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ValidateFunc: validation.IsDayOfTheWeek(true), |
There was a problem hiding this comment.
I did not validate this also works with capitalized weekdays. The provider docs list lowercase examples but in the case of database clusters I tested and both were accepted by the DO API.
There was a problem hiding this comment.
I think ignoring case here is correct, but in addition to days of the week, DOKS maintenance policies can also set any if the user has no preference.
validation.IsDayOfTheWeek is just a thin wrapper around validation.StringInSlice. So we can use that here it support any as well.
There was a problem hiding this comment.
Ah right, I missed that even though I saw it in the docs.
I updated it and amended my commit. Hope that's alright.
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ValidateFunc: validation.IsDayOfTheWeek(true), |
There was a problem hiding this comment.
I think ignoring case here is correct, but in addition to days of the week, DOKS maintenance policies can also set any if the user has no preference.
validation.IsDayOfTheWeek is just a thin wrapper around validation.StringInSlice. So we can use that here it support any as well.
moreinhardt
force-pushed
the
add-maintenance-day-validation
branch
from
c831635 to
c5dd54e
Compare
moreinhardt
force-pushed
the
add-maintenance-day-validation
branch
from
c5dd54e to
7fe8510
Compare
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"any", "monday", "tuesday", "wednesday", "thursday", "friday", "saturday", "sunday"}, true), |
There was a problem hiding this comment.
I don't have much experience with Go. I see that Go has no line length limit. So go fmt didn't complain or change this.
Should I wrap this to have every value on a separate line for readability?
The docs did not really tell me how to use this field.