Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RISDEV-6627 Add PUT endpoint #188

Merged
merged 2 commits into from
Feb 13, 2025
Merged

RISDEV-6627 Add PUT endpoint #188

merged 2 commits into from
Feb 13, 2025

Conversation

andreas-deazevedo
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ris-adm-vwv-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ris-adm-vwv-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andreas-deazevedo andreas-deazevedo merged commit 8005d67 into main Feb 13, 2025
25 checks passed
@andreas-deazevedo andreas-deazevedo deleted the RISDEV-6627_add_put_endpoint branch February 13, 2025 08:09
hannes-mk
hannes-mk reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@hannes-mk hannes-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two things I enjoyed most:

  • The controllers being slim "data transformers"
  • Refactorings of existing code

I'll need another session on how the tests work, exactly.
End of sprint is fine.

.editorconfig Show resolved Hide resolved
...rc/main/java/de/bund/digitalservice/ris/adm_vwv/adapter/api/DocumentationUnitController.java Show resolved Hide resolved
...bund/digitalservice/ris/adm_vwv/adapter/persistence/DocumentationUnitPersistenceService.java Show resolved Hide resolved
...rc/main/java/de/bund/digitalservice/ris/adm_vwv/application/CreateDocumentationUnitPort.java Show resolved Hide resolved
...rc/main/java/de/bund/digitalservice/ris/adm_vwv/application/CreateDocumentationUnitPort.java Show resolved Hide resolved
...est/java/de/bund/digitalservice/ris/adm_vwv/adapter/api/DocumentationUnitControllerTest.java Show resolved Hide resolved
...est/java/de/bund/digitalservice/ris/adm_vwv/adapter/api/DocumentationUnitControllerTest.java Show resolved Hide resolved
...est/java/de/bund/digitalservice/ris/adm_vwv/adapter/api/DocumentationUnitControllerTest.java Show resolved Hide resolved
...est/java/de/bund/digitalservice/ris/adm_vwv/adapter/api/DocumentationUnitControllerTest.java Show resolved Hide resolved
backend/src/main/java/de/bund/digitalservice/ris/adm_vwv/application/DocumentationUnit.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-mk hannes-mk hannes-mk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-deazevedo @hannes-mk