Use GetDigestOIDForSignatureAlgorithm to set the digest algorithm OID

[malancas]

Small follow up PR to digitorus/pkcs7#11. This pull request uses pkcs7.GetDigestOIDForSignatureAlgorithm to set the digest algorithm used in the signing process. Currently the digest algorithm is hardcoded to SHA-256. This PR also fixes a few small typos.

[codecov]

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.31% ⚠️

Comparison is base (0faba6f) 66.45% compared to head (a0d362a) 66.15%.
Report is 1 commits behind head on master.

❗ Current head a0d362a differs from pull request most recent head e686ea5. Consider uploading reports for the commit e686ea5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   66.45%   66.15%   -0.31%     
==========================================
  Files           3        3              
  Lines         322      325       +3     
==========================================
+ Hits          214      215       +1     
- Misses         70       71       +1     
- Partials       38       39       +1     

Flag	Coverage Δ
unittests	66.15% <42.85%> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
rfc3161_struct.go	80.00% <0.00%> (ø)
timestamp.go	65.58% <50.00%> (-0.32%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vanbroup]

Can you check the lint errors and test coverage?

[malancas]

Sure, I'll take a look

[malancas]

Reviewing the linter failure, it looks like it could be due to the linter GitHub Action being out of date. Updating to golangci/golangci-lint-action@v3 may help.

Reviewing the codecov failures, it looks like most of them are responding to code changes that fix typos. Do you know if the codecov warnings can be disabled for these lines?

[malancas]

I updated the golangci-lint Action to the latest version, I think an older version was causing the linting failure. I also pushed a codecov config that disables alerts for patching. The alerts seem a bit noisy since they were mostly around line changes related to typo corrections.

[malancas]

@vanbroup just wanted to follow up around the linter and codecov updates as resolution to the workflow failures.