Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from slice-deque to its fork slice-ring-buffer #4

Closed
wants to merge 2 commits into from
Closed

Conversation

hko-s
Copy link

@hko-s hko-s commented Aug 1, 2024

slice-deque is unmaintained, "cargo test" doesn't run successfully anymore. the slice-ring-buffer fork is mentioned in gnzlbg/slice_deque#94

slice-deque is unmaintained, "cargo test" doesn't run successfully anymore.
the slice-ring-buffer fork is mentioned in gnzlbg/slice_deque#94
Cargo.toml Outdated
version = "0.3"
optional = true

[features]
default = ["slice-deque"]
default = ["slice-ring-buffer"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the feature name the same and use dep: notation to activate the dep

@hko-s
Copy link
Author

hko-s commented Aug 1, 2024

The forked crate's SliceRingBuffer::tail_head_slice() returns &mut [[MaybeUninit](https://doc.rust-lang.org/nightly/core/mem/maybe_uninit/union.MaybeUninit.html)<T>], which seems to make the abstraction over the different buffer implementations unhappy :-/

@hko-s
Copy link
Author

hko-s commented Aug 1, 2024

closing in favor of #5

@hko-s hko-s closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants