Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunity Summary Fields #27

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

pxwxnvermx
Copy link
Contributor

This PR includes the code for UI to add summary fields for an opportunity and adds the summary fields to the API serializer for the opportunity.

Ticket Link

  • Opportunity Create Form:
image
  • Opportunity API Schema: /api/v1/opportunity/
[
  {
    "id": 0,
    "name": "string",
    "description": "string",
    "date_created": "2023-07-18T11:47:48.929Z",
    "date_modified": "2023-07-18T11:47:48.929Z",
    "organization": "string",
    "learn_app": {
      "cc_domain": "string",
      "cc_app_id": "string",
      "name": "string",
      "description": "string",
      "organization": "string"
    },
    "deliver_app": {
      "cc_domain": "string",
      "cc_app_id": "string",
      "name": "string",
      "description": "string",
      "organization": "string"
    },
    "end_date": "2023-07-18",
    "max_visits_per_user": 2147483647,
    "daily_max_visits_per_user": 2147483647,
    "budget_per_visit": 2147483647,
    "total_budget": 2147483647
  }
]

@pxwxnvermx pxwxnvermx self-assigned this Jul 18, 2023
Copy link
Collaborator

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The PR is still a 'draft'. Are you planning to add more?

@pxwxnvermx pxwxnvermx marked this pull request as ready for review July 19, 2023 06:05
@pxwxnvermx
Copy link
Contributor Author

Looks good. The PR is still a 'draft'. Are you planning to add more?

Nope, I was just taking a final look at the changes.

@pxwxnvermx pxwxnvermx merged commit c87e972 into main Jul 19, 2023
2 checks passed
@pxwxnvermx pxwxnvermx deleted the pkv/opportunity-summary-fields branch July 19, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants