Merge pull request #34605 from dimagi/gh/es/fix-bug-with-reindex-output

Gevent doesn't guarantee ordering when calculating ES adapter doc counts

corehq/apps/es/management/commands/elastic_sync_multiplexed.py

@@ -161,17 +161,23 @@ def display_source_destination_doc_count(self, adapter):
         """
         es_manager.index_refresh(adapter.primary.index_name)
         es_manager.index_refresh(adapter.secondary.index_name)
-
         self.perform_cleanup(adapter)
 
+        def get_doc_count(_adapter):
+            return {_adapter.index_name: _adapter.count({})}
+
         greenlets = gevent.joinall([
-            gevent.spawn(adapter.count, {}),
-            gevent.spawn(adapter.secondary.count, {})
+            gevent.spawn(get_doc_count, adapter.primary),
+            gevent.spawn(get_doc_count, adapter.secondary)
         ])
-        primary_count, secondary_count = [g.get() for g in greenlets]
+        counts = {}
+        for greenlet in greenlets:
+            counts.update(greenlet.get())
 
-        print(f"\nDoc Count In Old Index '{adapter.primary.index_name}' - {primary_count}")
-        print(f"\nDoc Count In New Index '{adapter.secondary.index_name}' - {secondary_count}\n\n")
+        print(f"\nDoc Count In Old Index '{adapter.primary.index_name}' - {counts[adapter.primary.index_name]}")
+        print(
+            f"\nDoc Count In New Index '{adapter.secondary.index_name}' - {counts[adapter.secondary.index_name]}\n"
+        )
 
     def display_backfill_subindex_doc_counts_for_domain(self, source_adapter, destination_adapter, domain):
         if not destination_adapter.parent_index_cname: