Added security watchtower page #35400

mjriley · 2024-11-19T19:45:47Z

Product Description

Added a new page for the security watchtower

Technical Summary

This is currently an empty page. It is awaiting new tiles that will be implemented as part of our enterprise console improvements.

Feature Flag

This is hidden behind the ENTERPRISE_DASHBOARD_IMPROVEMENTS feature flag.

Safety Assurance

Safety story

This is currently an empty page hidden behind a user flag that no users should have enabled. I verified the changes to the enterprise console page locally, testing that the page continued to display correctly and also verified generating the domain report.

Automated test coverage

No tests

QA Plan

No QA

Rollback instructions

This PR can be reverted after deploy with no further considerations

Labels & Review

Risk label is set correctly
The set of people pinged as reviewers is appropriate for the level of risk of the change

biyeun · 2024-11-20T16:15:51Z

The breadcrumbs should be updated to show

Enterprise Console / Security Watchtower

And relatedly

Enterprise Console / Enterprise Dashboard

See this utility

commcare-hq/corehq/apps/hqwebapp/context.py

Line 7 in 8da6e78

    
           def get_page_context(page_title, page_url, page_name=None, parent_pages=None, domain=None, section=None):

(not a blocker: can be part of this or a small followup PR)

biyeun · 2024-11-20T16:20:59Z

corehq/apps/enterprise/static/enterprise/js/enterprise_dashboard.js

@@ -191,30 +191,35 @@ hqDefine("enterprise/js/enterprise_dashboard", [
    }

    $(function () {


would be nice to make this an es6 / esm module and use js_entry

Also, since this entry point will be used for both enterprise_dashboard and security_watchtower, would be good to rename the file so that it's clear it's not specific to either. e.g. enterprise_dashboard => enterprise_report_tiles?

Alternative...rename enterprise dashboard page to project health metrics?

Or "Project Overview"?

Or "Enterprise Overview"?

Addressed in f35b96f

biyeun · 2024-11-20T16:26:34Z

corehq/apps/enterprise/templates/enterprise/enterprise_dashboard.html

@@ -2,7 +2,7 @@
 {% load hq_shared_tags %}
 {% load i18n %}

-{% block page_title %}{{ account.name }}{% endblock %}
+{% block page_title %}{{ header_title }}{% endblock %}

 {% requirejs_main_b5 'enterprise/js/enterprise_dashboard' %}


please migrate to webpack thank you!

requirejs_main_b5 => js_entry

and then

import 'commcarehq`;

at the top of the esm module

Given work like #35409, this is going to cause conflicts. I think we should handle this as a separate PR

biyeun · 2024-11-20T16:34:28Z

corehq/apps/enterprise/static/enterprise/js/enterprise_dashboard.js

+            const maxDateRangeDays = initialPageData.get("max_date_range_days");
+            dateRangeModal = DateRangeModal(datePicker, dateRangePresetOptions, maxDateRangeDays, formSubmissionsDisplay);
+
+            $("#dateRangeDisplay").koApplyBindings(formSubmissionsDisplay);


Suggested change

$("#dateRangeDisplay").koApplyBindings(formSubmissionsDisplay);

$dateRangeDisplay.koApplyBindings(formSubmissionsDisplay);

Addressed in 9519faf

biyeun · 2024-11-20T16:43:36Z

corehq/apps/enterprise/views.py

+    if not has_privilege(request, privileges.PROJECT_ACCESS):
+        return HttpResponseRedirect(reverse(EnterpriseBillingStatementsView.urlname, args=(domain,)))
+
+    context = {


would be good to use

commcare-hq/corehq/apps/hqwebapp/context.py

Line 7 in 8da6e78

def get_page_context(page_title, page_url, page_name=None, parent_pages=None, domain=None, section=None):

use page_title and page_name

page_name is "Security Watchtower for <request.account.name>"

and then specify a Section so the breadcrumbs work properly

Addressed in 54bb2aa

biyeun · 2024-11-20T16:44:58Z

corehq/apps/enterprise/templates/enterprise/enterprise_dashboard.html

@@ -2,7 +2,7 @@
 {% load hq_shared_tags %}
 {% load i18n %}

-{% block page_title %}{{ account.name }}{% endblock %}
+{% block page_title %}{{ header_title }}{% endblock %}


current_page.name

Addressed in 54bb2aa

…r to Security Center

jingcheng16 · 2024-11-27T15:59:06Z

@mjriley All changes looks good
If I remember correctly, in last group review session, we agreed on implementing a partial template for the tile?

mjriley · 2024-12-02T18:55:34Z

@mjriley All changes looks good If I remember correctly, in last group review session, we agreed on implementing a partial template for the tile?

Should be addressed in 63d6b28

jingcheng16 · 2024-12-02T19:42:32Z

@mjriley Thank you! Since data range modal is only used in tile, should it be moved into the partial template too?
{% include 'enterprise/partials/date_range_modal.html' %}

Is there anything below can be moved to the partial template?

  {% registerurl "enterprise_dashboard_email" domain "---" %}
  {% registerurl "enterprise_dashboard_total" domain "---" %}
  {% initial_page_data 'max_date_range_days' max_date_range_days %}
  {% initial_page_data 'metric_type' metric_type %}

mjriley · 2024-12-03T15:26:06Z

@mjriley Thank you! Since data range modal is only used in tile, should it be moved into the partial template too? {% include 'enterprise/partials/date_range_modal.html' %}

Is there anything below can be moved to the partial template?
  {% registerurl "enterprise_dashboard_email" domain "---" %}
  {% registerurl "enterprise_dashboard_total" domain "---" %}
  {% initial_page_data 'max_date_range_days' max_date_range_days %}
  {% initial_page_data 'metric_type' metric_type %}

I think that might create undesired behavior? The template is going to be included for every report. If we were to include the modal or register the URLs within this partial template, I believe that would cause us to generate a separate modal and register separate URLs for each time the partial was included.

jingcheng16 · 2024-12-03T15:52:02Z

@mjriley Interesting! I didn't think about that! Thank you!

Added security watchtower page

d73e066

mjriley added the product/feature-flag Change will only affect users who have a specific feature flag enabled label Nov 19, 2024

mjriley requested review from biyeun and jingcheng16 November 19, 2024 19:45

Base automatically changed from mjr/enterprise_console_ff to master November 20, 2024 15:40

biyeun reviewed Nov 20, 2024

View reviewed changes

mjriley added 3 commits November 21, 2024 15:39

refactor to use get_page_context

54bb2aa

Small renaming fix

9519faf

rename Enterprise Console to Platform Overview and Security Watchtowe…

f35b96f

…r to Security Center

mjriley requested a review from orangejenny as a code owner November 21, 2024 21:03

mjriley added 2 commits November 21, 2024 16:54

Merge branch 'master' into mjr/security_watchtower

d33ce72

Bootstrap 5 Migration - Rebuilt diffs

f6b2732

biyeun approved these changes Nov 26, 2024

View reviewed changes

extract project tile template

63d6b28

jingcheng16 approved these changes Dec 3, 2024

View reviewed changes

mjriley merged commit 23682ba into master Dec 3, 2024
13 checks passed

mjriley deleted the mjr/security_watchtower branch December 3, 2024 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added security watchtower page #35400

Added security watchtower page #35400

mjriley commented Nov 19, 2024

biyeun commented Nov 20, 2024 •

edited

Loading

biyeun Nov 20, 2024

biyeun Nov 20, 2024

biyeun Nov 20, 2024

biyeun Nov 20, 2024

mjriley Nov 21, 2024

biyeun Nov 20, 2024

biyeun Nov 20, 2024

mjriley Nov 21, 2024

biyeun Nov 20, 2024

mjriley Nov 21, 2024

biyeun Nov 20, 2024

biyeun Nov 20, 2024

mjriley Nov 21, 2024

biyeun Nov 20, 2024 •

edited

Loading

mjriley Nov 21, 2024

jingcheng16 commented Nov 27, 2024

mjriley commented Dec 2, 2024

jingcheng16 commented Dec 2, 2024

mjriley commented Dec 3, 2024

jingcheng16 commented Dec 3, 2024

		@@ -191,30 +191,35 @@ hqDefine("enterprise/js/enterprise_dashboard", [
		}

		$(function () {

	$("#dateRangeDisplay").koApplyBindings(formSubmissionsDisplay);
	$dateRangeDisplay.koApplyBindings(formSubmissionsDisplay);

Added security watchtower page #35400

Added security watchtower page #35400

Conversation

mjriley commented Nov 19, 2024

Product Description

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Rollback instructions

Labels & Review

biyeun commented Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

biyeun Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingcheng16 commented Nov 27, 2024

mjriley commented Dec 2, 2024

jingcheng16 commented Dec 2, 2024

mjriley commented Dec 3, 2024

jingcheng16 commented Dec 3, 2024

biyeun commented Nov 20, 2024 •

edited

Loading

biyeun Nov 20, 2024 •

edited

Loading