[B5] Commtrack SMS settings action table #35454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_table.html' as complete and un-split files.
orangejenny
added
the
product/feature-flag
millerdev
approved these changes
Nov 27, 2024
|
@orangejenny |
|
@jingcheng16 Good question. The feature flag controlling this page is marked "deprecated," but there are still a few existing projects using the functionality. I'll update the description to be clearer. |
…magi/commcare-hq into jls/b5-commtrack-action-table
jingcheng16
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Best I can tell, I just missed this template altogether when doing #34309 I probably missed testing the error messages, since other than those, the B3 version doesn't look that out of place even when the rest of the page is B5.
I think the domain B5 split might have affected this, since the before screenshot (which is from staging) doesn't look exactly the same as the "after" screenshot from #34309
Before
After
Feature Flag
Commtrack
Safety Assurance
Safety story
Minor UI changes on a page that's behind a feature flag, and that feature flag is only being used by a few projects.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review