Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

43 parameter inputs can be make more robust #45

Merged
merged 5 commits into from
Sep 27, 2024
Merged

43 parameter inputs can be make more robust #45

merged 5 commits into from
Sep 27, 2024

Conversation

RobertManningSmith
Copy link
Collaborator

Created a test suite to check reading in data from parameter files

@RobertManningSmith
work around for column order in ODMs
2ad6803
@RobertManningSmith
Created a test suite that checks that the model can run without certa…
8434abe 
…in parameter files being declared and that if something has gone wrong in loading in parameters, the model will raise error
@RobertManningSmith RobertManningSmith linked an issue Sep 17, 2024 that may be closed by this pull request
parameter inputs can be make more robust #43
Closed
swise5
swise5 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@swise5 swise5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes reviewed; many deletions done here to allow for modular updating of the codebase, which is great. Parameter inputs much cleaner this way.

@swise5 swise5 merged commit 0ddb9ca into main Sep 27, 2024
@swise5 swise5 deleted the 43-parameter-inputs-can-be-make-more-robust branch September 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swise5 swise5 swise5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parameter inputs can be make more robust
2 participants
@RobertManningSmith @swise5